Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types to CheckboxGroup #16642

Conversation

2nikhiltom
Copy link
Contributor

Closes #16584

Add types to CheckboxGroup

Changelog

New
Added interfaces for props, state and internal variables.

Changed
renamed CheckboxGroup.js to CheckboxGroup.tsx

Testing / Reviewing

building
viewing the CheckboxGroup stories
creating a component that uses CheckboxGroup and testing which props are valid/invalid

@2nikhiltom 2nikhiltom requested a review from a team as a code owner June 3, 2024 09:36
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be9d051
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/665d8eb35294f20008ad5901
😎 Deploy Preview https://deploy-preview-16642--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit be9d051
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/665d8eb3b4c9d30008ffed4e
😎 Deploy Preview https://deploy-preview-16642--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2nikhiltom
Copy link
Contributor Author

will be tracked via #16643

@2nikhiltom 2nikhiltom closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to CheckboxGroup
1 participant